Hi Marek, > Subject: Re: [PATCH v5 2/2] mmc: renesas-sdhi: Add R8A774A1 SDHI quirks > > On 10/8/20 10:59 AM, Biju Das wrote: > > Add various SDHI quirks for R8A774A1 SoC. > > > > Signed-off-by: Biju Das <biju.das...@bp.renesas.com> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev- > lad...@bp.renesas.com> > > --- > > v5 : New Patch > > --- > > drivers/mmc/renesas-sdhi.c | 18 ++++++++++++------ > > 1 file changed, 12 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/mmc/renesas-sdhi.c b/drivers/mmc/renesas-sdhi.c > > index d80b3fc28f..40e01ed890 100644 > > --- a/drivers/mmc/renesas-sdhi.c > > +++ b/drivers/mmc/renesas-sdhi.c > > @@ -870,7 +870,8 @@ static void renesas_sdhi_filter_caps(struct udevice > *dev) > > /* HS400 is not supported on H3 ES1.x and M3W ES1.0, ES1.1 */ > > if (((rmobile_get_cpu_type() == RMOBILE_CPU_TYPE_R8A7795) && > > (rmobile_get_cpu_rev_integer() <= 1)) || > > - ((rmobile_get_cpu_type() == RMOBILE_CPU_TYPE_R8A7796) && > > + (((rmobile_get_cpu_type() == RMOBILE_CPU_TYPE_R8A7796) || > > + (rmobile_get_cpu_type() == RMOBILE_CPU_TYPE_R8A774A1)) && > > Hmm ... this code is growing real complex. > > Would it be too hard to add soc_device_attribute (see Linux) to U-Boot and > clean that code above up ? Or maybe there is already something similar in U- > Boot to match on SoC revision ?
OK, Agreed. will use soc_device_match to add quirks. Regards, Biju