On Mon, Nov 02, 2020 at 08:24:09AM +0100, Marek Behun wrote: > On Mon, 2 Nov 2020 08:27:16 +0800 > Qu Wenruo <w...@suse.com> wrote: > > > Thus I really tend to believe it's just a bug in coverity. > > All locations accessing @ii all have its key.type checked to ensure it get > > filled in the first place. > > If this is a bug in coverity, we should fix coverity, not add extra > code to U-Boot, even if it is just one instruction. That simply stinks > the same way like when systemd crashed when "debug" parameter was > present in /proc/cmdline, and they sent a patch to kernel which removed > the "debug" parameter, instead of fixing systemd. IMO.
To be clear, I am quite happy to mark as intentional any issues that are flagged by Coverity but, well, intentional and not a problem. We may also benefit from adding a "modeling" file to help Coverity know when some cases of issues are handled by us already. -- Tom
signature.asc
Description: PGP signature