Hi Simon, Thanks for the feedback.
> Subject: Re: [PATCH v2 2/3] dm: soc: Add SoC id for attribute matching > > Hi Biju, > > On Mon, 2 Nov 2020 at 08:10, Biju Das <biju.das...@bp.renesas.com> wrote: > > > > Add SoC identification string for attribute matching. > > Also changed the comments from "an SOC" to "an SoC". > > Please put this second bit in a separate patch, perhaps before this one in the > series. OK. Will split the patch into two and post v3. Regards, Biju > Otherwise it looks good to me. > > > > Signed-off-by: Biju Das <biju.das...@bp.renesas.com> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev- > lad...@bp.renesas.com> > > --- > > v1->v2: Changed the comments from "a SoC" to "an SoC" > > --- > > drivers/soc/soc-uclass.c | 19 ++++++++++++++++++- > > drivers/soc/soc_sandbox.c | 8 ++++++++ > > include/soc.h | 39 +++++++++++++++++++++++++++++++++------ > > test/dm/soc.c | 8 ++++++++ > > 4 files changed, 67 insertions(+), 7 deletions(-) > >