On Sun, Nov 01, 2020 at 02:15:41PM -0700, Simon Glass wrote: > At present the 'nlen' variable increases with each loop. If the previous > loop had back references, then subsequent loops without back references > use the wrong value of nlen. The value is larger, meaning that the string > terminator from nbuf is copied along to the main buffer, thus terminating > the string prematurely. > > This leads to the final result being truncated, e.g. missing the last > (unmatched) part of the string. So "match match tail" become > "replaced replaced" instead of "replaced replaced tail". > > Fix this by resetting nlen to the correct value each time around the lop. > > Fixes: 855f18ea0e6 ("setexpr: add regex substring matching and substitution") > Signed-off-by: Simon Glass <s...@chromium.org>
Applied to u-boot/next, thanks! -- Tom
signature.asc
Description: PGP signature