hi Simon, On Sat, 12 Dec 2020 at 21:10, Simon Glass <s...@chromium.org> wrote:
> Hi Sughosh, > > On Fri, 11 Dec 2020 at 03:06, Sughosh Ganu <sughosh.g...@linaro.org> > wrote: > > > > The fsp_types.h header file contains macros for building signatures of > > different widths. These signature macros are architecture agnostic, > > and can be used in all places which use signatures in a data > > structure. Move and rename the fsp_types.h under the common include > > header. > > > > Signed-off-by: Sughosh Ganu <sughosh.g...@linaro.org> > > --- > > > > Build tested for cougarcanyon2 board which builds the > > relevant fsp code. > > > > arch/x86/include/asm/fsp/fsp_support.h | 3 ++- > > .../asm/fsp/fsp_types.h => include/signature_types.h | 6 +++--- > > How about just signatures.h ? > Ok. Will change. > > 2 files changed, 5 insertions(+), 4 deletions(-) > > rename arch/x86/include/asm/fsp/fsp_types.h => > include/signature_types.h (94%) > > > > diff --git a/arch/x86/include/asm/fsp/fsp_support.h > b/arch/x86/include/asm/fsp/fsp_support.h > > index 29e511415c..7651a0dac0 100644 > > --- a/arch/x86/include/asm/fsp/fsp_support.h > > +++ b/arch/x86/include/asm/fsp/fsp_support.h > > @@ -11,10 +11,11 @@ > > #include <asm/fsp/fsp_fv.h> > > #include <asm/fsp/fsp_hob.h> > > #include <asm/fsp/fsp_infoheader.h> > > -#include <asm/fsp/fsp_types.h> > > #include <asm/fsp_arch.h> > > #include <asm/fsp/fsp_azalia.h> > > > > +#include <signature_types.h> > > Can you put that at the top, as we normally put asm headers below common > ones. > Sure, I will re-arrange. Thanks for your review. -sughosh
