Hi Andy, On Mon, 21 Dec 2020 at 05:03, Andy Shevchenko <andriy.shevche...@linux.intel.com> wrote: > > On Fri, Dec 18, 2020 at 07:29:21PM -0700, Simon Glass wrote: > > On Wed, 16 Dec 2020 at 16:16, Andy Shevchenko > > <andriy.shevche...@linux.intel.com> wrote: > > > > > > Refactor iomux_doenv() a bit in order to increase readability. > > > There is no change in code generation on x86. > > ... > > > Reviewed-by: Simon Glass <s...@chromium.org> > > Thanks! > > ... > > > event better: > > > > if (temp) > > I didn't get this. Can you elaborate what exactly you had in mind? > Because... > > > > + temp = strchr(temp, ','); > > > + if (temp == NULL) > > ...here is a new code.
It would help if I wrote it for the new code. I just mean: if (temp == NULL) is better written in U-Boot as if (!temp) > > > > + break; > > > + > > > + temp++; > > > Since you gave Rb tag I'll leave as is for now. Yes that's fine. Regards, Simon