On 12/27/20 6:50 PM, Heinrich Schuchardt wrote:
> Freeing a buffer before calling hang() is superfluous. Removing the call
> reduces the SPL size.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de>

Reviewed-by: Jaehoon Chung <jh80.ch...@samsung.com>

Best Regards,
Jaehoon Chung

> ---
>  drivers/mmc/fsl_esdhc_spl.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/mmc/fsl_esdhc_spl.c b/drivers/mmc/fsl_esdhc_spl.c
> index afe55fad9d..bee76572ac 100644
> --- a/drivers/mmc/fsl_esdhc_spl.c
> +++ b/drivers/mmc/fsl_esdhc_spl.c
> @@ -91,20 +91,17 @@ void __noreturn mmc_boot(void)
>                                       CONFIG_CFG_DATA_SECTOR, 1, tmp_buf);
>       if (err != 1) {
>               puts("spl: mmc read failed!!\n");
> -             free(tmp_buf);
>               hang();
>       }
> 
>       val = *(tmp_buf + MBRDBR_BOOT_SIG_55);
>       if (0x55 != val) {
>               puts("spl: mmc signature is not valid!!\n");
> -             free(tmp_buf);
>               hang();
>       }
>       val = *(tmp_buf + MBRDBR_BOOT_SIG_AA);
>       if (0xAA != val) {
>               puts("spl: mmc signature is not valid!!\n");
> -             free(tmp_buf);
>               hang();
>       }
> 
> --
> 2.29.2
> 
> 

Reply via email to