On Wed, Jan 6, 2021 at 9:24 PM Tom Rini <tr...@konsulko.com> wrote:
>
> On Wed, Jan 06, 2021 at 08:39:56PM +0800, Bin Meng wrote:
> > On Sun, Dec 20, 2020 at 9:21 PM Bin Meng <bmeng...@gmail.com> wrote:
> > >
> > > Use the dtc executable generated during the U-Boot build process for
> > > mkimage. This removes the build dependency on the external dtc.
> > >
> > > Signed-off-by: Bin Meng <bmeng...@gmail.com>
> > > ---
> > >
> > > tools/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> >
> > Ping?
>
> OK. I _think_ this is wrong. This changes the compiled in path to
> "dtc" that mkimage will have. We don't want the system-wide installed
> "mkimage" tool to call out to "scripts/dtc/dtc", but either "dtc" (so
> that normal PATH parsing works) or possibly a less-obvious path to the
> system-wide dtc (based on my commit message about FreeBSD having it in
> some other location).
Agreed. That's probably why commit 1f6049e2501b ("tools/mkimage: Make
the path to the dtc binary that mkimage calls configurable") was
introduced. Thanks!
Regards,
Bin
