On Wed, Feb 10, 2021 at 08:46:51AM +0800, Bin Meng wrote: > Hi Simon, > > On Sun, Feb 7, 2021 at 11:34 PM Simon Glass <s...@chromium.org> wrote: > > > > Hi Bin, > > > > On Sun, 7 Feb 2021 at 08:11, Bin Meng <bmeng...@gmail.com> wrote: > > > > > > This reverts commit e002474158d1054a7a2ff9a66149384c639ff242. > > > > > > Commit e002474158d1 ("pci: pci-uclass: Dynamically allocate the PCI > > > regions") > > > changes 'struct pci_controller'.regions from pre-allocated array of > > > regions to dynamically allocated, which unfortunately broken lots of > > > boards that still use the non-DM PCI driver. > > > > > > We may update every non-DM PCI board codes to do the dynamical > > > allocation of PCI regions but that's a lot of work (e.g.: almost > > > all Freescale PowerPC boards are broken now and need to be fixed). > > > Let's do the easy way. > > > > No one has noticed since July, apparently. I think it would be better > > to disable PCI on these boards, until either someone migrates them or > > they are removed. The PCI deadline was about 18 months ago. > > > > Yep, but I'd like to keep this revert instead of just fixing the > qemu-ppce500 here, to give people a chance to test their original > non-DM version of PCI driver before the DM conversion. > > Once all boards have converted to DM PCI, we can revert this revert patch > again.
I'm not quite sure as a number of PowerPC boards did convert. I will see what's left, on top of the series I'm currently testing that deals with LIBATA+AHCI (and in turn kills off some PowerPC stuff). -- Tom
signature.asc
Description: PGP signature