Hi Green, On Tue, Mar 16, 2021 at 10:33 AM Green Wan <green....@sifive.com> wrote: > > > > On Thu, Mar 11, 2021 at 10:21 PM Bin Meng <bmeng...@gmail.com> wrote: >> >> On Thu, Mar 11, 2021 at 9:50 PM Green Wan <green....@sifive.com> wrote: >> > >> > Add dts, defconfig and board support for HiFive Unmatched. >> > >> > Signed-off-by: Green Wan <green....@sifive.com> >> > --- >> > arch/riscv/dts/fu740-hifive-unmatched-a00-ddr.dtsi | 1489 >> > ++++++++++++++++++++ >> > arch/riscv/dts/hifive-unmatched-a00-u-boot.dtsi | 40 + >> > arch/riscv/dts/hifive-unmatched-a00.dts | 263 ++++ >> > board/sifive/fu540/Kconfig | 1 - >> > board/sifive/fu540/fu540.c | 2 +- >> >> It looks these fu540 changes are not needed? > > Let me remove the change for fu540 first and check on fu540. > >> >> >> > board/sifive/hifive_unmatched_fu740/Kconfig | 50 + >> > board/sifive/hifive_unmatched_fu740/MAINTAINERS | 9 + >> > board/sifive/hifive_unmatched_fu740/Makefile | 9 + >> >> > .../hifive-unmatched-fu740.c | 24 + >> > board/sifive/hifive_unmatched_fu740/spl.c | 85 ++ >> > configs/sifive_hifive_unmatched_fu740_defconfig | 57 + > > I'd like to rename "board/sifive/hifive_unmatched_fu740" to the shorter > name "board/sifive/unmatched". And > "configs/sifive_hifive_unmatched_fu740_defconfig" to > "configs/sifive_unmatched_defconfig" in v2 patch.
Agree. I sent a patch to rename fu540 to unleashed, so that this is consistent. http://patchwork.ozlabs.org/project/uboot/patch/20210316030622.40768-1-bmeng...@gmail.com/ You may rebase v2 on top of that patch. > >> >> > doc/board/sifive/fu540.rst | 19 +- >> >> here? >> >> > doc/board/sifive/hifive_unmatched_fu740.rst | 532 +++++++ >> > drivers/reset/Kconfig | 2 +- >> > include/configs/sifive-fu540.h | 5 - >> >> and here? Regards, Bin