Reviewed-by: Andy Wu <andy...@sony.com>
Best Regards
Andy Wu
> -----Original Message-----
> From: U-Boot <u-boot-boun...@lists.denx.de> On Behalf Of
> yuezhang...@sony.com
> Sent: Wednesday, March 17, 2021 2:45 PM
> To: u-boot@lists.denx.de
> Cc: peng....@nxp.com; pa...@antoniou-consulting.com
> Subject: [PATCH] Revert "mmc: sdhci: set to INT_DATA_END when there are
> data"
>
> This reverts commit 17ea3c862865c0d704646f67dbf8412f9ff54f59.
>
> In eMMC specification, for the response-with-busy(R1b, R5b) command, the
> DAT0 will driven to LOW as BUSY status, and in sdhci specification, the
> transfer
> complete bit should be wait for BUSY status de-assert.
>
> All response-with-busy commands don't contain data, the data judgement is no
> need.
>
> Signed-off-by: Yuezhang.Mo <yuezhang...@sony.com>
> ---
> drivers/mmc/sdhci.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index
> d9ab6a0a83..8568f65b18 100644
> --- a/drivers/mmc/sdhci.c
> +++ b/drivers/mmc/sdhci.c
> @@ -258,8 +258,7 @@ static int sdhci_send_command(struct mmc *mmc,
> struct mmc_cmd *cmd,
> flags = SDHCI_CMD_RESP_LONG;
> else if (cmd->resp_type & MMC_RSP_BUSY) {
> flags = SDHCI_CMD_RESP_SHORT_BUSY;
> - if (data)
> - mask |= SDHCI_INT_DATA_END;
> + mask |= SDHCI_INT_DATA_END;
> } else
> flags = SDHCI_CMD_RESP_SHORT;
>
> --
> 2.25.1
