Hi Sean, Thanks for the review. I fix almost of the issues. Will upload the v3 soon.
Still have some questions. Sean Anderson 於 2021/3/23 下午11:06 寫道: > > > > if (anatop_reg->supply) { > ret = regulator_set_value(anatop_reg->supply, uV + 150000); > if (ret) > return ret; > } > What is 150000? Is it the min_dropout_uV? Should I set it to 125000 instead? > > > > ret = regulator_set_enable(sreg->supply, true); > if (ret) > return ret; > Since vin-supply is optional, I change it to ret = device_get_supply_regulator(dev, "vin-supply", &anatop_reg->supply); if (!ret) { ret = regulator_set_enable(anatop_reg->supply, true); if (ret) return ret; } Is this ok? > > + > > + ret = ofnode_read_u32(dev_ofnode(dev), > > > +U_BOOT_DRIVER(anatop_regulator) = { > > + .name = "anatop_regulator", > > + .id = UCLASS_REGULATOR, > > + .ops = &anatop_regulator_ops, > > + .of_match = of_anatop_regulator_match_tbl, > > + .plat_auto = sizeof(struct anatop_regulator), > > + .probe = anatop_regulator_probe, > > +}; > > Yours, Paul