Dear Wolfgang Denk, > In message<4cc09695.6070...@rocketmail.com> you wrote: >> Labels added to endifs to aid readability of the net/bootp.c file. >> A block of code was marked for conditional compilation but the condition >> could never arise, the ifdef\endif code block has been deleted. > ... > >> -#if defined(CONFIG_CMD_DHCP) >> - *e++ = 53; /* DHCP Message Type */ >> - *e++ = 1; >> - *e++ = DHCP_DISCOVER; >> - >> - *e++ = 57; /* Maximum DHCP Message Size */ >> - *e++ = 2; >> - *e++ = (576 - 312 + OPT_SIZE)>> 16; >> - *e++ = (576 - 312 + OPT_SIZE)& 0xff; >> -#endif > > What makes you think CONFIG_CMD_DHCP was never used? There are 270+ > boards that use this!
Its in the ELSE part like this: #if defined(CONFIG_CMD_DHCP) ... #else ... #if defined(CONFIG_CMD_DHCP) ... #endif ... #endif Perhaps it should be investigated how it happened to become such dead code? Best Regards, Reinhard _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot