Re: [[PATCH] colibri_imx6: add board_fit_config_name_match to support FIT in SPL

[Sean Anderson]

On 6/1/21 11:58 AM, Ming Liu wrote:

Hi, Sean:

Thanks for the comments, please see my answers as follows:

 > Please use an errno.

Seems all other board are using '0' and '-1' as return value of 
board_fit_config_name_match, shouldn't we keep consistent with them?

*shrug*

We return an int, so why not use an error code? Otherwise, we might as
well return bool.

 > Do you need to match "imx6-colibri", or could you use the default config?

I think so since imx6-colibri.its is the only present DTS file for this board.

//Ming Liu

So does this FIT only contain one config? I ask because if you just
need the default config you can use the weak definition in
common/common_fit.c.

--Sean

Sean Anderson <sean...@gmail.com <mailto:sean...@gmail.com>> 於 2021年5月31日 週一 
下午4:36寫道：

    On 5/31/21 3:06 AM, liu.min...@gmail.com <mailto:liu.min...@gmail.com> 
wrote:
     > From: Ming Liu <liu.min...@gmail.com <mailto:liu.min...@gmail.com>>
     >
     > Only one dtb is currently supported, so match with imx6-colibri.
     >
     > Signed-off-by: Ming Liu <liu.min...@gmail.com 
<mailto:liu.min...@gmail.com>>
     > ---
     >   board/toradex/colibri_imx6/colibri_imx6.c | 10 ++++++++++
     >   1 file changed, 10 insertions(+)
     >
     > diff --git a/board/toradex/colibri_imx6/colibri_imx6.c 
b/board/toradex/colibri_imx6/colibri_imx6.c
     > index c0e7754469..587d92a8e9 100644
     > --- a/board/toradex/colibri_imx6/colibri_imx6.c
     > +++ b/board/toradex/colibri_imx6/colibri_imx6.c
     > @@ -1081,6 +1081,16 @@ void board_init_f(ulong dummy)
     >       board_init_r(NULL, 0);
     >   }
     >
     > +#ifdef CONFIG_SPL_LOAD_FIT
     > +int board_fit_config_name_match(const char *name)
     > +{
     > +     if (!strcmp(name, "imx6-colibri"))
     > +             return 0;
     > +
     > +     return -1;

    Please use an errno.

     > +}
     > +#endif
     > +
     >   void reset_cpu(void)
     >   {
     >   }
     >

    Do you need to match "imx6-colibri", or could you use the default config?

    --Sean