Hi Patrick.
On Fri, 4 Jun 2021 at 21:14, Patrick Wildt <patr...@blueri.se> wrote:
>
> Am Fri, Jun 04, 2021 at 04:56:07AM +0000 schrieb Anand Moon:
> > Replace msleep occurences by udelay.
> >
> > drivers/pci/pcie_dw_rockchip.c:254:3: warning: implicit
> > declaration of function 'msleep' [-Wimplicit-function-declaration]
> >
> > Cc: Patrick Wildt <patr...@blueri.se>
> > Cc: Neil Armstrong <narmstr...@baylibre.com>
> > Cc: Kever Yang <kever.y...@rock-chips.com>
> > Signed-off-by: Anand Moon <linux.am...@gmail.com>
> > ---
> > V2: drop the msleep macro.
> > ---
> > drivers/pci/pcie_dw_rockchip.c | 9 +++++----
> > 1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw_rockchip.c
> > index 4e448c0a3d..039266a357 100644
> > --- a/drivers/pci/pcie_dw_rockchip.c
> > +++ b/drivers/pci/pcie_dw_rockchip.c
> > @@ -62,6 +62,7 @@ struct rk_pcie {
> >
> > /* Parameters for the waiting for #perst signal */
> > #define PERST_WAIT_MS 1000
> > +#define MACRO_US 1000
> >
> > static int rk_pcie_read(void __iomem *addr, int size, u32 *val)
> > {
> > @@ -249,7 +250,7 @@ static int rk_pcie_link_up(struct rk_pcie *priv, u32
> > cap_speed)
> > * some wired devices need much more, such as 600ms.
> > * Add a enough delay to cover all cases.
> > */
> > - msleep(PERST_WAIT_MS);
> > + udelay(PERST_WAIT_MS);
>
> You're missing the * MACRO_US here. I'm not sure though that really
Thanks, I forgot to update, it got skipped.
> needs a macro for MS to US, or did someone request that?
Neil suggested something in my review commend.
Please replace msleep occurences by udelay with either:
- udelay(MACRO_MS * 1000)
- udelay(MACRO_US) and replace MACRO_MS with MACRO_US with values *1000
Opps I miss read the request.
Thanks
-Anand
