Hi Tero, On 11/06/21 2:15 pm, Tero Kristo wrote: > Hello, > > One more post, this time with the #ifdef hackery converted to use the > IS_ENABLED / CONFIG_IS_ENABLED macros, and also removed the "common.h" > include from k3-clk.h header. This version also contains fixes to any > build issues reported by Lokesh, and these are squashed in to relevant > patches.
Can you see if the below warnings can be fixed? hsm/0018-arm-mach-k3-add-support-for-detecting-firmware-image.patch ------------------------------------------------------------------- WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible #26: FILE: arch/arm/mach-k3/common.c:31: +#if IS_ENABLED(CONFIG_SYS_K3_SPL_ATF) WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible #35: FILE: arch/arm/mach-k3/common.c:40: +#if CONFIG_IS_ENABLED(FIT_IMAGE_POST_PROCESS) WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible #55: FILE: arch/arm/mach-k3/common.c:131: +#if IS_ENABLED(CONFIG_SYS_K3_SPL_ATF) WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible #124: FILE: arch/arm/mach-k3/common.c:264: +#if CONFIG_IS_ENABLED(FIT_IMAGE_POST_PROCESS) WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible #128: FILE: arch/arm/mach-k3/common.c:268: +#if IS_ENABLED(CONFIG_SYS_K3_SPL_ATF) WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible #150: FILE: arch/arm/mach-k3/common.c:290: +#if IS_ENABLED(CONFIG_TI_SECURE_DEVICE) total: 0 errors, 6 warnings, 0 checks, 144 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. hsm/0018-arm-mach-k3-add-support-for-detecting-firmware-image.patch has style problems, please review. ------------------------------------------------------------------- hsm/0019-arm-mach-k3-do-board-config-for-PM-only-if-supported.patch ------------------------------------------------------------------- WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible #24: FILE: arch/arm/mach-k3/sysfw-loader.c:162: +#if !CONFIG_IS_ENABLED(K3_DM_FW) total: 0 errors, 1 warnings, 0 checks, 13 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Thanks and regards, Lokesh