On Mon, Jun 28, 2021 at 01:20:05PM +0200, Heinrich Schuchardt wrote: > On 6/28/21 3:48 AM, Simon Glass wrote: > > This file does not correctly handle the various cases, sometimes > > producing warnings about partition_basic_data_guid being defined but not > > used. Fix it. > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > --- > > > > disk/part_efi.c | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/disk/part_efi.c b/disk/part_efi.c > > index 0fb7ff0b6bb..fdca91a6974 100644 > > --- a/disk/part_efi.c > > +++ b/disk/part_efi.c > > @@ -29,12 +29,13 @@ > > > > DECLARE_GLOBAL_DATA_PTR; > > > > -/* > > - * GUID for basic data partions. > > - */ > > +#ifdef CONFIG_HAVE_BLOCK_DEVICE > > This #ifdef should be removed. Make CONFIG_HAVE_BLOCK_DEVICE a > prerequisite for CONFIG_PARTITIONS instead.
Ah, this is where things get funny. No, you can't do that as you can use partitions without block devices. I think it was some xilinx setup that has this? -- Tom
signature.asc
Description: PGP signature
