Hello Tim, Am Mittwoch, den 14.07.2021, 15:42 -0700 schrieb Tim Harvey: > On Fri, Jun 18, 2021 at 4:14 AM Teresa Remmet <t.rem...@phytec.de> > wrote: > > There is no separate SPL/TPL config for WATCHDOG_AUTOSTART. > > So use IS_ENABLED instead of CONFIG_IS_ENABLED to make watchdog > > working in spl again. > > > > Signed-off-by: Teresa Remmet <t.rem...@phytec.de> > > --- > > drivers/watchdog/wdt-uclass.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/watchdog/wdt-uclass.c b/drivers/watchdog/wdt- > > uclass.c > > index 268713529604..f113a65fc187 100644 > > --- a/drivers/watchdog/wdt-uclass.c > > +++ b/drivers/watchdog/wdt-uclass.c > > @@ -51,7 +51,7 @@ int initr_watchdog(void) > > 4 * > > reset_period) / 4; > > } > > > > - if (!CONFIG_IS_ENABLED(WATCHDOG_AUTOSTART)) { > > + if (!IS_ENABLED(CONFIG_WATCHDOG_AUTOSTART)) { > > printf("WDT: Not starting\n"); > > return 0; > > } > > -- > > 2.25.1 > > > > Maybe add a 'Fixes: 830d29ac3721 ("watchdog: Allow to use CONFIG_WDT > without starting watchdog")' to the commit message?
yes, this would make more clear. I will send a v2 with a updated commit message. Thanks, Teresa > > I'm more interested in just someone picking this up as without it SPL > watchdog is broken. > > Tim