Hi Simon, On Mon, Aug 02, 2021 at 08:44:28AM -0600, Simon Glass wrote: > The changes to move from devicetree to rodata take things in the wrong > direction for various reasons: >
As I said on the previous thread, I think this should remain as is for a number of reasons (and mainly because it only works with 1/3 valid CONFIG_OF_XXX U-Boot provides), but I'll let Heinrich decide. > - devicetree is where config should be stored > - it provides no memory production in any case, particularly when U-Boot > is relocated > - testing becomes harder, with the suggestion of adding an entire new > sandbox build just for this > > Revert this until a new direction can be established. > Regards /Ilias > Changes in v2: > - Also revert two other patches, based on comment from Takahiro > > Simon Glass (3): > Revert "doc: Update CapsuleUpdate READMEs" > Revert "mkeficapsule: Remove dtb related options" > Revert "efi_capsule: Move signature from DTB to .rodata" > > board/emulation/common/Makefile | 1 + > board/emulation/common/qemu_capsule.c | 43 ++++ > doc/board/emulation/qemu_capsule_update.rst | 203 +++++++++++++++++ > doc/develop/uefi/uefi.rst | 125 ----------- > include/asm-generic/sections.h | 2 - > lib/efi_loader/Kconfig | 7 - > lib/efi_loader/Makefile | 8 - > lib/efi_loader/efi_capsule.c | 18 +- > lib/efi_loader/efi_capsule_key.S | 17 -- > tools/mkeficapsule.c | 229 +++++++++++++++++++- > 10 files changed, 472 insertions(+), 181 deletions(-) > create mode 100644 board/emulation/common/qemu_capsule.c > create mode 100644 doc/board/emulation/qemu_capsule_update.rst > delete mode 100644 lib/efi_loader/efi_capsule_key.S > > -- > 2.32.0.554.ge1b32706d8-goog >