Hi Simon, On Sun, Aug 15, 2021 at 2:27 PM Tony Dinh <mibo...@gmail.com> wrote: > > Hi Simon, > > On Sun, Aug 15, 2021 at 7:10 AM Simon Glass <s...@chromium.org> wrote: > > > > Hi Tony, > > > > On Thu, 5 Aug 2021 at 22:49, Tony Dinh <mibo...@gmail.com> wrote: > > > > > > > > > At the moment, there is no common fdt helper function specific to > > > decoding network related > > > information from FDTs. This new helper functional group fdt_support_net > > > is intended to be used > > > by board-specific code within U-Boot for various network related chores. > > > > > > In this patch, create the 1st function fdt_get_phy_addr to parse the > > > device tree to find > > > the PHY addess of a specific ethernet device. > > > > > > > > > Tony Dinh (3): > > > Add fdt network helper header file > > > Add fdt network helper functions > > > Add fdt network helper to Makefile > > > > > > common/Makefile | 2 +- > > > common/fdt_support_net.c | 46 +++++++++++++++++++++++++++++++++++++++ > > > include/fdt_support_net.h | 39 +++++++++++++++++++++++++++++++++ > > > 3 files changed, 86 insertions(+), 1 deletion(-) > > > create mode 100644 common/fdt_support_net.c > > > create mode 100644 include/fdt_support_net.h > > > > Can this use livetre and also have some tests? > > I have not enabled livetree for any of the boards I have. So I just > modeled this using the existing ./common/fdt_support.c! > > I do agree we should start using livetree in fdt helpers, if I > understood it correctly, it should work for both flattree and > livetree. Perhaps we could have another patch series after this? I am > preparing another Kirkwood board support patch that I could hold off > submitting and enable livetree to use that as a vehicle for testing. > > Thanks, > Tony > > > Regards, > > Simon
So is it OK for this patch to be accepted as is? It'll take a while for me to switch to the livetree approach and do testing. Thanks, Tony