On Tue, Aug 24, 2021 at 1:02 PM Marek Vasut <ma...@denx.de> wrote:
>
> On 8/24/21 6:43 PM, Adam Ford wrote:
> > There are two versaclock programmable clock chips used to provide
> > reference clocks for both USB and Ethernet.  Enable the driver
> > in the configs to run these clocks.
> >
> > Signed-off-by: Adam Ford <aford...@gmail.com>
> >
> > diff --git a/configs/r8a774a1_beacon_defconfig 
> > b/configs/r8a774a1_beacon_defconfig
> > index 7ba4ac05f5..002b91176f 100644
> > --- a/configs/r8a774a1_beacon_defconfig
> > +++ b/configs/r8a774a1_beacon_defconfig
> > @@ -39,7 +39,9 @@ CONFIG_VERSION_VARIABLE=y
> >   CONFIG_REGMAP=y
> >   CONFIG_SYSCON=y
> >   CONFIG_CLK=y
> > +CONFIG_CLK_CCF=y
> >   CONFIG_CLK_RENESAS=y
> > +CONFIG_CLK_VERSACLOCK=y
>
> There is a lot of duplication here, look into
> arch/arm/mach-rmobile/Kconfig.64 and for TARGET_BEACON_RZG2M (where are
> the others?) add "select CLK_VERSACLOCK" . You can also fix it up and
> add whatever other mandatory config options should be enabled for that
> platform. And then you reduce the defconfig too.

Are you OK if i put that into board/beacon/beacon-rzg2m/Kconfig?
there is a check to see if TARGET_BEACON_RZG2H || TARGET_BEACON_RZG2M
|| TARGET_BEACON_RZG2N is set.  From there, i should be able to select
the common options that are required and it won't have to be
duplicated in either the defconfigs or the
arch/arm/mach-rmobile/Kconfig.64

adam

Reply via email to