Re: [PATCH] board: ea: mx7ulp_com: allow setting CONFIG_BOOTCOMMAND in defconfig

[Tom Rini]

On Wed, Aug 25, 2021 at 04:37:49PM +0300, Oleksandr Suvorov wrote:

> From: Ricardo Salveti <rica...@foundries.io>
> 
> Allow replacing the board defined CONFIG_BOOTCOMMAND via defconfig.
> 
> Signed-off-by: Ricardo Salveti <rica...@foundries.io>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvo...@foundries.io>
> ---
> 
>  include/configs/mx7ulp_com.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/configs/mx7ulp_com.h b/include/configs/mx7ulp_com.h
> index 28672c4f94..85ae513ffb 100644
> --- a/include/configs/mx7ulp_com.h
> +++ b/include/configs/mx7ulp_com.h
> @@ -69,10 +69,12 @@
>                       "bootz ${loadaddr} - ${fdt_addr}; " \
>               "fi;\0" \
>  
> +#ifndef CONFIG_BOOTCOMMAND
>  #define CONFIG_BOOTCOMMAND \
>       "if run loadimage; then " \
>               "run mmcboot; " \
>       "fi; " \
> +#endif
>  
>  #define CONFIG_SYS_LOAD_ADDR         CONFIG_LOADADDR

Please just move this to the defconfig.  It's not a long/complex
command, which is the general (understandable) excuse to not migrate it.

-- 
Tom

signature.asc
Description: PGP signature