Hi Teresa,

On Wed, Aug 25, 2021 at 12:25 PM Teresa Remmet <t.rem...@phytec.de> wrote:
>
> binman conversion made flashing flash.bin
> and u-boot.itb necessary. Update binman config
> to create a single flash.bin image again.
>
> This updates imx8mp_evk and phyCORE-i.MX8MP as they share the
> same binman config.
>
> Updated also imx8mp_evk documentation.
>
> Tested on phyCORE-i.MX8MP.

Thanks for taking care of this.

> Signed-off-by: Teresa Remmet <t.rem...@phytec.de>
> ---
>  arch/arm/dts/imx8mp-u-boot.dtsi                 | 17 ++++++++++++++++-
>  .../imx8mp_evk/imximage-8mp-lpddr4.cfg          |  2 +-
>  board/phytec/phycore_imx8mp/imximage-8mp-sd.cfg |  2 +-
>  doc/board/nxp/imx8mp_evk.rst                    |  1 -
>  4 files changed, 18 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/dts/imx8mp-u-boot.dtsi b/arch/arm/dts/imx8mp-u-boot.dtsi
> index a6ede2ed6e30..ace7b2051e7f 100644
> --- a/arch/arm/dts/imx8mp-u-boot.dtsi
> +++ b/arch/arm/dts/imx8mp-u-boot.dtsi
> @@ -82,7 +82,7 @@
>                 };
>         };
>
> -       flash {
> +       spl {

To make this more standard, could you please also pass 'filename =
"spl.bin" here too?

Please check:
https://lists.denx.de/pipermail/u-boot/2021-August/458754.html

>  BOOT_FROM      sd
> -LOADER         mkimage.flash.mkimage   0x920000
> +LOADER         mkimage.spl.mkimage     0x920000

Please use "LOADER u-boot-spl-ddr.bin  0x920000" here instead.

> diff --git a/board/phytec/phycore_imx8mp/imximage-8mp-sd.cfg 
> b/board/phytec/phycore_imx8mp/imximage-8mp-sd.cfg
> index b2920b4908ed..2be18de674ba 100644
> --- a/board/phytec/phycore_imx8mp/imximage-8mp-sd.cfg
> +++ b/board/phytec/phycore_imx8mp/imximage-8mp-sd.cfg
> @@ -7,4 +7,4 @@
>
>  ROM_VERSION    v2
>  BOOT_FROM      sd
> -LOADER         mkimage.flash.mkimage   0x920000
> +LOADER         mkimage.spl.mkimage     0x920000

Ditto.

With these changes, you can add:

Reviewed-by: Fabio Estevam <feste...@gmail.com>

Thanks

Reply via email to