On Mon, Aug 30, 2021 at 11:31:28PM +0800, Huang Jianan wrote: > 在 2021/8/30 21:27, Huang Jianan 写道: > > > > > > 在 2021/8/26 6:39, Tom Rini 写道: > > > On Mon, Aug 23, 2021 at 08:36:44PM +0800, Huang Jianan wrote: > > > > > > > From: Huang Jianan <huangjia...@oppo.com> > > > > > > > > This patch mainly deals with uncompressed files. > > > > > > > > Signed-off-by: Huang Jianan <huangjia...@oppo.com> > > > > --- > > > > fs/Kconfig | 1 + > > > > fs/Makefile | 1 + > > > > fs/erofs/Kconfig | 12 ++ > > > > fs/erofs/Makefile | 7 + > > > > fs/erofs/data.c | 124 ++++++++++++++ > > > > fs/erofs/erofs_fs.h | 384 > > > > ++++++++++++++++++++++++++++++++++++++++++++ > > > > fs/erofs/fs.c | 231 ++++++++++++++++++++++++++ > > > > fs/erofs/internal.h | 203 +++++++++++++++++++++++ > > > > fs/erofs/namei.c | 238 +++++++++++++++++++++++++++ > > > > fs/erofs/super.c | 65 ++++++++ > > > > fs/fs.c | 22 +++ > > > > include/erofs.h | 19 +++ > > > > include/fs.h | 1 + > > > > 13 files changed, 1308 insertions(+) > > > > create mode 100644 fs/erofs/Kconfig > > > > create mode 100644 fs/erofs/Makefile > > > > create mode 100644 fs/erofs/data.c > > > > create mode 100644 fs/erofs/erofs_fs.h > > > > create mode 100644 fs/erofs/fs.c > > > > create mode 100644 fs/erofs/internal.h > > > > create mode 100644 fs/erofs/namei.c > > > > create mode 100644 fs/erofs/super.c > > > > create mode 100644 include/erofs.h > > > Do the style problems checkpatch.pl complains about here match what's in > > > the linux kernel? I expect at lease some of them come from using custom > > > debug/etc macros rather than the standard logging functions. Thanks. > > > > The code is mainly come from erofs-utils, thems it has the same problem, > > i > > will fix it ASAP. > > > > Thanks, > > Jianan > > > I have checked checkpatch.pl complains, some need to be fixed, and some > come frome using custom macros. It seems that there are still some warnings > that are inconsistent with the linux kernel, such as : > > WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where > possible > #835: FILE: fs/erofs/fs.c:224: > +#ifdef CONFIG_LIB_UUID > > WARNING: Possible switch case/default not preceded by break or fallthrough > comment > #763: FILE: fs/erofs/zmap.c:489: > + case Z_EROFS_VLE_CLUSTER_TYPE_NONHEAD: > > erofs-utils is written according to the linux kernel coding style, I expect > this > part can be consistent in order to reduce maintenance burden and keep > with the latest feature.
Yes, please fix what can be easily fixed and still kept in sync with other projects. -- Tom
signature.asc
Description: PGP signature
