Dear Adam Ford, In message <20210927183030.506532-1-aford...@gmail.com> you wrote: > The macro called MUX_VAL generates a writel instruction with > semicolon at the end. This table was written to use semicolons, > however one was missed: > > MUX_VAL(CP(SYS_BOOT2), (IEN | PTD | DIS | M4)) /* GPIO_4 */ > > Since the extra semicolon is unnecessary with the use of the macro, > remove all of them.
Thanks. .... > + MUX_VAL(CP(MCSPI2_SOMI), (IEN | PTD | DIS | M0)) > /*HSUSB2_DATA5*/ > + MUX_VAL(CP(MCSPI2_CS0), (IEN | PTD | EN | M0)) > /*HSUSB2_DATA6*/ > + MUX_VAL(CP(MCSPI2_CLK), (IEN | PTD | DIS | M0)) > /*HSUSB2_DATA7*/ > MUX_VAL(CP(SYS_BOOT2), (IEN | PTD | DIS | M4)) /* GPIO_4 */ This line stands out because indentation is different from all the other lines. You might want to fix that, too, while we are at it? Reviewd-by: Wolfgang Denk <w...@denx.de> Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de When a program is being tested, it is too late to make design changes. -- Geoffrey James, "The Tao of Programming"
