Hi Takahiro, On Mon, 11 Oct 2021 at 19:42, AKASHI Takahiro <takahiro.aka...@linaro.org> wrote: > > Simon, > > On Mon, Oct 11, 2021 at 08:54:09AM -0600, Simon Glass wrote: > > Hi Takahiro, > > > > On Thu, 7 Oct 2021 at 00:25, AKASHI Takahiro <takahiro.aka...@linaro.org> > > wrote: > > > > > > With this script, a public key is added to a device tree blob > > > as the default efi_get_public_key_data() expects. > > > > > > Signed-off-by: AKASHI Takahiro <takahiro.aka...@linaro.org> > > > --- > > > MAINTAINERS | 1 + > > > tools/fdtsig.sh | 40 ++++++++++++++++++++++++++++++++++++++++ > > > 2 files changed, 41 insertions(+) > > > create mode 100755 tools/fdtsig.sh > > > > Instead of an ad-hoc script with no tests, > > Basically I intended to provide fdtsig.sh as a *sample* script so that > people may want to integrate the logic into their own build rule/systems. > But I could use this script in my 'capsule authentication' test > that is also added in patch#22. > > > could we use binman for > > putting the image together and inserting it? > > First, as you can see, the script is quite simple and secondly, > the purpose of binman, IIUC, is to help handle/manipulate U-Boot > image binaries. > So I'm not sure whether it is really useful to add such a feature to binman.
I'm not sure. The script seems very ad-hoc to me, for a feature that Linaro is pushing so hard. I don't see where the script is used in the tests or even mentioned in the documentation. Am I missing something? Regards, Simon