On Wed, Oct 27, 2021 at 06:10:59PM +0800, Bin Meng wrote: > On Wed, Oct 27, 2021 at 4:52 PM Andy Shevchenko > <andy.shevche...@gmail.com> wrote: > > On Wed, Oct 27, 2021 at 5:57 AM Bin Meng <bmeng...@gmail.com> wrote: > > > On Sat, Oct 16, 2021 at 1:27 AM Andy Shevchenko > > > <andriy.shevche...@linux.intel.com> wrote:
... > > > > + cd-inverted; > > > > > > So I wonder how sd card ever worked without the "cd-inverted" property? > > > > TL;DR: it worked on one PCB design and did not work on the other. When > > we disconnect the pin the read value is always the same and inverted > > to what we expected in the code. > > Great. That explains. Although I read the below comments a couple of > times, it just did not come to my head that "when we disconnect the > pin the read value is always the same and inverted to what we expected > in the code." Sure! > > Have you read the commit message and the comment below? Have you read > > the bug report? > > Yes, but it's not crystal clear hence the ask. So maybe we can update > the comments to make such clearer? Yep, I'll do it for the next version. > > > > + /* > > > > + * Disconnect SD card detect, so it won't affect the > > > > reality > > > > + * on two different PCB designs where it's using the > > > > opposite > > > > + * signaling: Edison/Arduino uses Active Low, while > > > > SparkFun > > > > + * went with Active High. > > > > + */ > > FWIW, > Reviewed-by: Bin Meng <bmeng...@gmail.com> Thanks! -- With Best Regards, Andy Shevchenko