Hi Simon, [...] > > > > +int tpm_tis_open(struct udevice *udev); > > Please add comments
There are comments for all of those in drivers/tpm/tpm2_tis_core.c, isn't that enough? Thanks /Ilias > > > +int tpm_tis_close(struct udevice *udev); > > +int tpm_tis_cleanup(struct udevice *udev); > > +int tpm_tis_send(struct udevice *udev, const u8 *buf, size_t len); > > +int tpm_tis_recv(struct udevice *udev, u8 *buf, size_t count); > > +int tpm_tis_get_desc(struct udevice *udev, char *buf, int size); > > +int tpm_tis_init(struct udevice *udev); > > +void tpm_tis_ops_register(struct udevice *udev, struct tpm_tis_phy_ops > > *ops); > > #endif > > diff --git a/include/tpm-v2.h b/include/tpm-v2.h > > index 13b3db67c60f..e6b68769f3ff 100644 > > --- a/include/tpm-v2.h > > +++ b/include/tpm-v2.h > > @@ -396,6 +396,7 @@ enum { > > TPM_STS_DATA_EXPECT = 1 << 3, > > TPM_STS_SELF_TEST_DONE = 1 << 2, > > TPM_STS_RESPONSE_RETRY = 1 << 1, > > + TPM_STS_READ_ZERO = 0x23 > > }; > > > > enum { > > -- > > 2.33.1 > > > > Regards, > Simon