On 11/14/2010 11:18 PM, Wolfgang Denk wrote: > Dear Sergiy Kibrik, > > In message <4cd27f08.8060...@globallogic.com> you wrote: >> Improved default config for OMAP4 Pandaboard for faster boot: >> -reduced environment size to speed up memory initialization; >> -USB TTY driver turned off; >> -tweaked blob load address to avoid image relocation (according to >> default uImage load address); >> >> Signed-off-by: Sergiy Kibrik <sergiy.kib...@globallogic.com> >> --- >> include/configs/omap4_panda.h | 8 ++++---- >> 1 files changed, 4 insertions(+), 4 deletions(-) > ... >> - * Total Size Environment - 256k >> + * Total Size Environment - 2k >> * Malloc - add 256k >> */ >> -#define CONFIG_ENV_SIZE (256 << 10) >> +#define CONFIG_ENV_SIZE (256 << 4) > > I think we had this discussion before. "256 << 4" makes no sense when > you mean 2 KiB - it requires the reader to actually perform the > calculation, which means it makes it hard for him to understand the > code. Without need. Please either write 2048, which everybody can > parse easily, or write "2 << 10" which can be parsed easily well. >
I've considered advices you gave me in this thread: http://marc.info/?t=128897628400001&r=1&w=2 and resubmitted the patch http://marc.info/?l=u-boot&m=128922349828119&w=2 Haven't you received that? -regards, Sergey _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
