Hi Ariel, The patch looks good. Only some minor comments:
On Tue, Nov 16, 2021 at 12:51 AM Ariel D'Alessandro <ariel.dalessan...@collabora.com> wrote: > > Add support for iMX8MN VAR-SOM-MX8M-NANO board. Enables support for: > > - 1GiB DDR4 RAM > - 16 GiB eMMC > - SD card > - Gigabit ethernet > - USBOTG1 peripheral - fastboot > > Signed-off-by: Ariel D'Alessandro <ariel.dalessan...@collabora.com> It would be nice to have a README file so that the users can know how to build and flash mainline U-Boot in this board. > +#define PHYS_SDRAM 0x40000000 > +#define PHYS_SDRAM_SIZE SZ_1G /* 1GB DDR */ > + > +#define CONFIG_BAUDRATE 115200 This is the default. No need to be specified here. > +#define CONFIG_MXC_UART_BASE UART4_BASE_ADDR > + > +/* Monitor Command Prompt */ > +#define CONFIG_SYS_CBSIZE SZ_2K > +#define CONFIG_SYS_MAXARGS 64 > +#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE > +#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ > + sizeof(CONFIG_SYS_PROMPT) + 16) > + > +/* USDHC */ > +#define CONFIG_FSL_USDHC This should be placed in defconfig. > +#define CONFIG_SYS_FSL_USDHC_NUM 2 This is not used. Please remove it.