Hi Heinrich, On Sun, 14 Nov 2021 at 02:32, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > > On 11/14/21 04:21, Simon Glass wrote: > > At present there are Kconfig options for tracing, but sandbox uses > > plain #defines to set them. Correct this and make the tracing command > > default to enabled so that this is not needed. > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > --- > > > > cmd/Kconfig | 2 ++ > > doc/develop/trace.rst | 14 +++++++------- > > 2 files changed, 9 insertions(+), 7 deletions(-) > > > > diff --git a/cmd/Kconfig b/cmd/Kconfig > > index 5b30b13e438..fd8f0227c89 100644 > > --- a/cmd/Kconfig > > +++ b/cmd/Kconfig > > @@ -2350,6 +2350,8 @@ config CMD_LOG > > > > config CMD_TRACE > > bool "trace - Support tracing of function calls and timing" > > + depends on TRACE > > + default y > > help > > Enables a command to control using of function tracing within > > U-Boot. This allows recording of call traces including timing > > diff --git a/doc/develop/trace.rst b/doc/develop/trace.rst > > index 7776c484286..34bce5d4677 100644 > > --- a/doc/develop/trace.rst > > +++ b/doc/develop/trace.rst > > @@ -30,16 +30,16 @@ Sandbox is a build of U-Boot that can run under Linux > > so it is a convenient > > way of trying out tracing before you use it on your actual board. To do > > this, follow these steps: > > > > -Add the following to include/configs/sandbox.h (if not already there) > > +Add the following to config/sandbox_defconfig (if not already there) > > > > .. code-block:: c > > > > - #define CONFIG_TRACE > > - #define CONFIG_CMD_TRACE > > - #define CONFIG_TRACE_BUFFER_SIZE (16 << 20) > > - #define CONFIG_TRACE_EARLY_SIZE (8 << 20) > > - #define CONFIG_TRACE_EARLY > > - #define CONFIG_TRACE_EARLY_ADDR 0x00100000 > > + CONFIG_TRACE=y > > + CONFIG_TRACE_BUFFER_SIZE=0x01000000 > > + CONFIG_TRACE_BUFFER_SIZE=0x01000000 > > This line is duplicate. And it is anyway the default value in > lib/Kconfig:229. So both lines can be removed. > > > + CONFIG_TRACE_EARLY_SIZE=0x800000 > > Is the CONFIG_TRACE_EARLY default inadequate and should be changed?
Yes it is helpful to have it a lot larger for sandbox. > > > > + CONFIG_TRACE_EARLY=y > > + CONFIG_TRACE_EARLY_ADDR=0x00100000 > > This is the default value. The line can be removed. Right, but this is documentation, so I think it is important to have everything in there, isn't it? Regards, Simon