On 11/16/2010 04:44 PM, Ben Gardiner wrote:
> On Tue, Nov 16, 2010 at 5:06 AM, Stefano Babic <sba...@denx.de> wrote:
>> This board uses the OMAP-L138 SOM stacked on a
>> custom baseboard. It supports SPI Flash, Ethernet
>> with RMII.
>>
>> Signed-off-by: Stefano Babic <sba...@denx.de>
>> ---
>> Changes since V2:
>> - Make clear that the code is taken from da850evm.c
>> and not da830evm.c (Ben Gardiner)
>> - factorize function to enable RMII (Ben Gardiner)
>
> previous versions were based on Sugosh's and my patches. Is that still true?
Yes, it is not changed.
>> +void davinci_emac_mii_mode_sel(int mode_sel);
> I'm sorry I didn't mention this before -- I was just reviewing my
> pending RMII patch and noticed the following:
>
> If this patch is based on the da850evm RMII support as previous
> version indicated then could this function prototype and the
> implementation below be wrapped in #if defined(CONFIG_DRIVER_TI_EMAC)
> and the corresponding declaration and implementations added to
> board/davinci/da8xxevm/common.{h,c} in the RMII patch be removed to
> minimize duplicate code?
I will protect prototype and implementation, but I prefer to not move
the code in da8xxevm/common.x. The ea20 board has its own directory, and
the place to share code among all davinci boards is under davinci/common
instead of under da8xxevm. And probably it should be better to protect
the function with CONFIG_SOC_DA8XX, too.
>
> You said you were going to remove this NAND stuff. It sounds like the
> ea20 will support NAND, so I've no qualms about keeping it around;
> just wondering if you forgot to remove it or forgot to mention that
> you weren't going to remove it?
The main reason is that I cannot test at the moment the NAND. I think
the best way to do is that I will provide another patch only when I will
get a new release of the board and I can test the NAND functionalities.
At the moment, this is dead code.
>> diff --git a/include/configs/da850evm.h b/include/configs/da850evm.h
>> index e4ae6f3..00d946e 100644
>> --- a/include/configs/da850evm.h
>> +++ b/include/configs/da850evm.h
>
> I think some da850evm.h changes creeped in by accident.
Yes, I noted too late, email was already sent ;-)
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de
=====================================================================
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
