Hi Alper, On Thu, 25 Nov 2021 at 10:40, Alper Nebi Yasak <alpernebiya...@gmail.com> wrote: > > From: "Marty E. Plummer" <hanet...@startmail.com> > > Add support for Kevin, an RK3399-based convertible chromebook that is > very similar to Bob. This patch is mostly based on existing support for > Bob, with only minor changes for Kevin-specific things. > > Unlike other Gru boards, coreboot sets Kevin's center logic to 925 mV, > so adjust it here in the dts as well. The rk3399-gru-kevin devicetree > has an unknown event code reference which has to be defined, set it > to the Linux counterpart. The new defconfig is copied from Bob with the > diffconfig: > > DEFAULT_DEVICE_TREE "rk3399-gru-bob" -> "rk3399-gru-kevin" > DEFAULT_FDT_FILE "rockchip/rk3399-gru-bob.dtb" -> > "rockchip/rk3399-gru-kevin.dtb" > VIDEO_ROCKCHIP_MAX_XRES 1280 -> 2400 > VIDEO_ROCKCHIP_MAX_YRES 800 -> 1600 > +TARGET_CHROMEBOOK_KEVIN y > > With this Kevin can boot from SPI flash to a usable U-Boot prompt on the > display with the keyboard working, but cannot boot into Linux for > unknown reasons. > > eMMC starts in a working state but fails to re-init, microSD card works > but at a lower-than-expected speed, USB works but causes a hang on > de-init. There are known workarounds to solve eMMC and USB issues. > > Cc: Marty E. Plummer <hanet...@startmail.com> > Cc: Simon Glass <s...@chromium.org> > [Alper: commit message, resync config with Bob, update MAINTAINERS, > add to Rockchip doc, add Kconfig help message, set regulator] > Co-developed-by: Alper Nebi Yasak <alpernebiya...@gmail.com> > Signed-off-by: Alper Nebi Yasak <alpernebiya...@gmail.com> > --- > Marty had signed-off an earlier version of this [1], but not the updated > version I continued on top of [2]. So I'm not sure if I can add his > sign-off to this as is, and I hope he can reply to this with a sign-off. > > [1] https://patchwork.ozlabs.org/patch/1053386/ > [2] https://patchwork.ozlabs.org/comment/2488899/ > > arch/arm/dts/Makefile | 1 + > arch/arm/dts/rk3399-gru-kevin-u-boot.dtsi | 11 ++ > arch/arm/mach-rockchip/rk3399/Kconfig | 11 ++ > arch/arm/mach-rockchip/rk3399/rk3399.c | 4 +- > arch/arm/mach-rockchip/spl.c | 3 +- > board/google/gru/Kconfig | 16 +++ > board/google/gru/MAINTAINERS | 8 ++ > board/google/gru/gru.c | 2 +- > configs/chromebook_kevin_defconfig | 116 ++++++++++++++++++ > doc/board/rockchip/rockchip.rst | 1 + > include/dt-bindings/input/linux-event-codes.h | 3 +- > 11 files changed, 171 insertions(+), 5 deletions(-) > create mode 100644 arch/arm/dts/rk3399-gru-kevin-u-boot.dtsi > create mode 100644 configs/chromebook_kevin_defconfig
This needs a rebase on next, just for a change in rk3399.c but I suppose it could be done when applying. Regards, Simon
