Hi Michael > -----Original Message----- > From: Michael Walle <mich...@walle.cc> > Sent: Monday, January 10, 2022 6:13 PM > To: Gaurav Jain <gaurav.j...@nxp.com> > Cc: Shengzhou Liu <shengzhou....@nxp.com>; Varun Sethi <v.se...@nxp.com>; > Adrian Alonso <adrian.alo...@nxp.com>; Alison Wang > <alison.w...@nxp.com>; Andy Tang <andy.t...@nxp.com>; > feste...@gmail.com; Franck Lenormand <franck.lenorm...@nxp.com>; Horia > Geanta <horia.gea...@nxp.com>; Ji Luo <ji....@nxp.com>; Meenakshi > Aggarwal <meenakshi.aggar...@nxp.com>; Mingkai Hu > <mingkai...@nxp.com>; olte...@gmail.com; Pankaj Gupta > <pankaj.gu...@nxp.com>; Peng Fan <peng....@nxp.com>; Pramod Kumar > <pramod.kuma...@nxp.com>; Priyanka Jain <priyanka.j...@nxp.com>; Rajesh > Bhagat <rajesh.bha...@nxp.com>; Sahil Malhotra <sahil.malho...@nxp.com>; > sba...@denx.de; Silvano Di Ninno <silvano.dini...@nxp.com>; > s...@chromium.org; u-boot@lists.denx.de; dl-uboot-imx <uboot-...@nxp.com>; > Wasim Khan <wasim.k...@nxp.com>; Ye Li <ye...@nxp.com>; Michael Walle > <mich...@walle.cc> > Subject: [EXT] Re: [PATCH v8 12/15] Layerscape: Enable Job ring driver model. > > Caution: EXT Email > > Hi, > > please keep me on CC for these series, as there were comments from me on > previous versions. Thanks. > > .. > > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index > > 7ce2bbc954..30a34bdd08 100644 > > --- a/arch/arm/Kconfig > > +++ b/arch/arm/Kconfig > > @@ -1504,6 +1504,8 @@ config TARGET_LS1028AQDS > > select ARCH_SUPPORT_TFABOOT > > select BOARD_LATE_INIT > > select GPIO_EXTRA_HEADER > > + select FSL_CAAM > > + select MISC > > This looks wrong. FSL_CAAM should depend on MISC, no? FSL_CAAM is to enable the CAAM driver. Caam driver is developed using misc uclass and MISC config is required to enable DM for misc uclass. Some platforms do not have driver model support so in that case CAAM can function without misc.
> > > help > > Support for Freescale LS1028AQDS platform > > The LS1028A Development System (QDS) is a high-performance @@ > > -1518,6 +1520,8 @@ config TARGET_LS1028ARDB > > select ARCH_SUPPORT_TFABOOT > > select BOARD_LATE_INIT > > select GPIO_EXTRA_HEADER > > + select FSL_CAAM > > + select MISC > > help > > Support for Freescale LS1028ARDB platform > > The LS1028A Development System (RDB) is a high-performance > > diff --git a/arch/arm/cpu/armv7/ls102xa/Kconfig > > b/arch/arm/cpu/armv7/ls102xa/Kconfig > > index f919d02db4..ca006e069f 100644 > > --- a/arch/arm/cpu/armv7/ls102xa/Kconfig > > +++ b/arch/arm/cpu/armv7/ls102xa/Kconfig > > @@ -21,6 +21,9 @@ config ARCH_LS1021A > > select SYS_FSL_SRDS_1 > > select SYS_HAS_SERDES > > select SYS_I2C_MXC > > + select FSL_CAAM > > While above you added that dependency to an indivdual board, here you are > adding that dependency to all boards using this architecture. The same is true > for all the other "config ARCH_*" symbols. What if someone wants to build a > bootloader without CAAM support? This should really go into the defconfigs for > these boards. CAAM is only initialized at boot which does not imply to use caam in every operation. Regards Gaurav Jain > > -michael
