On Mon, Jan 17, 2022 at 07:07:27AM -0800, Angus Ainslie wrote: > Initial commit of the librem5.h configuration > > Signed-off-by: Angus Ainslie <an...@akkea.ca>
You'll want to use CI (https://u-boot.readthedocs.io/en/latest/develop/ci_testing.html) to get this tested for migrated symbols, or copy the CI logic out to a script and do that manually as I suspect there's some symbols here that need to be in the defconfig. Also: > +#ifdef CONFIG_SPL_BUILD > +#define CONFIG_SPL_THERM_SUPPORT > +#define CONFIG_SPL_WATCHDOG_SUPPORT > +#define CONFIG_SPL_DRIVERS_MISC_SUPPORT > +#define CONFIG_SPL_LDSCRIPT "arch/arm/cpu/armv8/u-boot-spl.lds" > +#define CONFIG_SPL_STACK 0x187FF0 > +#define CONFIG_SPL_GPIO_SUPPORT > +#define CONFIG_SPL_MMC_SUPPORT > +#define CONFIG_SPL_BSS_START_ADDR 0x00180000 > +#define CONFIG_SPL_BSS_MAX_SIZE 0x2000 /* 8 KB */ > +#define CONFIG_SPL_STACK_R_ADDR 0x42300000 > +#define CONFIG_SPL_STACK_R > +#define CONFIG_SYS_SPL_MALLOC_START 0x42200000 > +#define CONFIG_SYS_SPL_MALLOC_SIZE 0x80000 /* 512 KB */ > +#define CONFIG_SYS_ICACHE_OFF > +#define CONFIG_SYS_DCACHE_OFF > + > +#define CONFIG_MALLOC_F_ADDR 0x182000 /* malloc f used before > GD_FLG_FULL_MALLOC_INIT */ > + > +#define CONFIG_SPL_ABORT_ON_RAW_IMAGE /* For RAW image gives a error info > not panic */ > + > +#undef CONFIG_SPL_DM_PMIC > +#undef CONFIG_SPL_DM_I2C > +#undef CONFIG_SPL_DM_PMIC_BD71837 > +#undef CONFIG_DM_USB > +#undef CONFIG_SPL_DM_USB > +#undef CONFIG_USB_DWC3_GENERIC > +#undef CONFIG_DEVRES > + > +#define CONFIG_SYS_I2C > + > +#define CONFIG_POWER_BD71837 > +#define CONFIG_POWER_BD71837_I2C_BUS 0 > +#define CONFIG_POWER_BD71837_I2C_ADDR 0x4B > + > +#define CONFIG_SPL_DMA_SUPPORT > + > +#define CONFIG_SYS_FSL_USDHC_NUM 1 > + > +#else /* CONFIG_SPL_BUILD*/ > + > +#define CONFIG_SYS_FSL_USDHC_NUM 2 > + > +#define CONFIG_USB_MAX_CONTROLLER_COUNT 1 > + > +#define CONFIG_USBD_HS > + > +#define CONFIG_USB_GADGET_VBUS_DRAW 2 > + > +#endif /* CONFIG_SPL_BUILD*/ You can't use CONFIG_SPL_BUILD in this way. Symbols need to always be set (and yes, this likely came from some other bad example). [snip] > + "bootargs=u_boot_version=" PLAIN_VERSION "\0" \ Why do you need this? It might be a problem for reproducible builds, and also you should just be able to use ${version} from the environment? Thanks. -- Tom
signature.asc
Description: PGP signature
