On 2/5/22 17:50, Tom Rini wrote:
On Sat, Feb 05, 2022 at 02:52:17PM +0100, Heinrich Schuchardt wrote:

Dear Tom,

The following changes since commit 3aaabfe9ff4bbcd11096513b1b28d1fb0a40800f:

   Merge branch 'master' of
https://source.denx.de/u-boot/custodians/u-boot-sunxi (2022-02-03
23:24:31 -0500)

are available in the Git repository at:

   https://source.denx.de/u-boot/custodians/u-boot-efi.git
tags/efi-2022-04-rc2

for you to fetch changes up to 8296548fe924678d9ac19ea3f69dca2fff879ab5:

   test/py: efi_capsule: check the results in case of
CAPSULE_AUTHENTICATE (2022-02-05 10:35:32 +0100)

Gitlab CI showed no issues:

https://source.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/10864


NAK, this breaks host tools on Windows and macOS:
https://dev.azure.com/u-boot/u-boot/_build/results?buildId=3589&view=results


I will create a new pull request without the mkeficapsule.c changes.

@Takahiro:
Please, address the issues.

https://dev.azure.com/u-boot/a1096300-2999-4ec4-a21a-4c22075e3771/_apis/build/builds/3589/logs/128:

2022-02-05T16:53:55.9574749Z   HOSTCC  tools/mkeficapsule
2022-02-05T16:53:56.1341775Z tools/mkeficapsule.c:18:10: fatal error:
uuid/uuid.h: No such file or directory
2022-02-05T16:53:56.1343964Z    18 | #include <uuid/uuid.h>
2022-02-05T16:53:56.1344702Z       |          ^~~~~~~~~~~~~
2022-02-05T16:53:56.1347501Z compilation terminated.
2022-02-05T16:53:56.1392680Z make[2]: *** [scripts/Makefile.host:95:
tools/mkeficapsule] Error 1

Instead of adding a dependency on uuid-dev it might be better to write
your own uuid_parse() function.

https://dev.azure.com/u-boot/a1096300-2999-4ec4-a21a-4c22075e3771/_apis/build/builds/3589/logs/122

Please, do not include malloc.h. The function malloc() is declared via
stdlib.h.

Best regards

Heinrich

Reply via email to