On Wed, Jan 12, 2022 at 12:47:06PM +0100, Rafał Miłecki wrote: > From: Rafał Miłecki <ra...@milecki.pl> > > Environment variables can be stored in two formats: > 1. Single entry with header containing CRC32 > 2. Two entries with extra flags field in each entry header > > For that reason fw_env_open() has two main code paths and there are > pointers for CRC32/flags/data. > > Previous implementation was a bit hard to follow: > 1. It was checking for used format twice (in reversed order each time) > 2. It was setting "environment" global struct fields to some temporary > values that required extra comments explaining it > > This change simplifies that code: > 1. It introduces two clear code paths > 2. It sets "environment" global struct fields values only once it really > knows them > > To be fair there are *two* crc32() calls now and an extra pointer > variable but that should be cheap enough and worth it. > > Signed-off-by: Rafał Miłecki <ra...@milecki.pl>
Applied to u-boot/master, thanks! -- Tom
signature.asc
Description: PGP signature
