On Sat, Feb 05, 2022 at 10:25:16AM +0000, qthedev wrote:

> echo -n does not give the intended effect when invoked in macOS through 
> /bin/sh, which is the shell make uses by default, see 
> "https://stackoverflow.com/questions/11675070/makefile-echo-n-not-working"; 
> for a detailed explanation. In this case, it resulted in "-n" being written 
> to env.txt and env.in even though they should be empty, which caused 
> compilation to fail with "Your board uses a text-file environment, so must 
> not define CONFIG_EXTRA_ENV_SETTINGS".
> 
> This patch prevents the error by replacing echo -n's with touch, as they are 
> used to create empty files in these cases.
> 
> diff --git a/Makefile b/Makefile
> index 184223ec63..3101aa0132 100644

Applied to u-boot/master, thanks!

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to