Re: [PATCH v2] ARM: imx: imx8mn-*-evk: use DM settings for PHY configuration

[Marek Vasut]

On 2/22/22 17:00, Michael Walle wrote:
Am 2022-02-22 16:19, schrieb Heiko Thiery:
With the correct settings described in the device-tree the PHY settings
in the board init are no longer required. The values are taken from the
linux device tree.
Suggested-by: Michael Walle <mich...@walle.cc>
Signed-off-by: Heiko Thiery <heiko.thi...@gmail.com>
---
v2:
 - remove phy-reset-gpios node (thanks to Michael)
    When using DM_ETH_PHY the reset-gpios from the phy is used

 arch/arm/dts/imx8mn-evk.dtsi            | 10 +++++++++-
 board/freescale/imx8mn_evk/imx8mn_evk.c | 16 ----------------
 2 files changed, 9 insertions(+), 17 deletions(-)

It seems someone was faster with this patch after all, thanks.

diff --git a/arch/arm/dts/imx8mn-evk.dtsi b/arch/arm/dts/imx8mn-evk.dtsi
index 416fadb22b..fd253f0042 100644
--- a/arch/arm/dts/imx8mn-evk.dtsi
+++ b/arch/arm/dts/imx8mn-evk.dtsi
@@ -53,7 +53,6 @@
     pinctrl-0 = <&pinctrl_fec1>;
     phy-mode = "rgmii-id";
     phy-handle = <&ethphy0>;
-    phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;

This ...

I'm afraid the phy reset in the phy node won't really end up toggling 
the PHY reset GPIO, would it ?

[...]