On 2/15/22 11:16 AM, Niklas Cassel wrote:
From: Niklas Cassel <niklas.cas...@wdc.com>

Using bias-pull-up would actually cause the pin to have its pull-down
enabled. Fix this.

Original Linux patch by Sean Anderson:
https://lore.kernel.org/linux-gpio/20220209182822.640905-1-sean...@gmail.com/

Fixes: 7224d5ccf8e1 ("pinctrl: Add support for Kendryte K210 FPIOA")
Signed-off-by: Niklas Cassel <niklas.cas...@wdc.com>
---
  drivers/pinctrl/pinctrl-k210.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-k210.c b/drivers/pinctrl/pinctrl-k210.c
index f809149102..13f0a34268 100644
--- a/drivers/pinctrl/pinctrl-k210.c
+++ b/drivers/pinctrl/pinctrl-k210.c
@@ -536,7 +536,7 @@ static int k210_pc_pinconf_set(struct udevice *dev, 
unsigned pin_selector,
                break;
        case PIN_CONFIG_BIAS_PULL_UP:
                if (argument)
-                       val |= K210_PC_PD;
+                       val |= K210_PC_PU;
                else
                        return -EINVAL;
                break;

Reviewed-by: Sean Anderson <sean...@gmail.com>

Reply via email to