On Fri, 2022-02-18 at 21:48 +0100, Heiko Thiery wrote: > The IMX_FEC_BASE value is not used when CONFIG_DM_ETH is configured. So this > value can be removed. > > Signed-off-by: Heiko Thiery <heiko.thi...@gmail.com> > --- > include/configs/imx8mm-cl-iot-gate.h | 2 -- > include/configs/imx8mm_beacon.h | 1 - > include/configs/imx8mm_evk.h | 2 -- > include/configs/imx8mm_venice.h | 1 -
Looks good. However, Tim already did this for the venice [1] which is why it no longer applies cleanly. With that fixed. Tested-by: Marcel Ziswiler <marcel.ziswi...@toradex.com> [1] https://patchwork.ozlabs.org/project/uboot/patch/20220211185206.9931-1-thar...@gateworks.com/ > include/configs/imx8mn_beacon.h | 1 - > include/configs/imx8mq_evk.h | 2 -- > include/configs/imx8mq_phanbell.h | 2 -- > include/configs/imx8ulp_evk.h | 2 -- > include/configs/kontron_pitx_imx8m.h | 1 - > include/configs/pico-imx8mq.h | 2 -- > include/configs/verdin-imx8mm.h | 1 - > 11 files changed, 17 deletions(-) > > diff --git a/include/configs/imx8mm-cl-iot-gate.h > b/include/configs/imx8mm-cl-iot-gate.h > index 7e6be6050c..4413bdcc58 100644 > --- a/include/configs/imx8mm-cl-iot-gate.h > +++ b/include/configs/imx8mm-cl-iot-gate.h > @@ -157,8 +157,6 @@ > #define CONFIG_FEC_MXC_PHYADDR 0 > #define FEC_QUIRK_ENET_MAC > > -#define IMX_FEC_BASE 0x30BE0000 > - > /* USB Configs */ > #define CONFIG_EHCI_HCD_INIT_AFTER_RESET > #define CONFIG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW) > diff --git a/include/configs/imx8mm_beacon.h b/include/configs/imx8mm_beacon.h > index 77f062474d..029e8c4c7f 100644 > --- a/include/configs/imx8mm_beacon.h > +++ b/include/configs/imx8mm_beacon.h > @@ -109,6 +109,5 @@ > #define CONFIG_FEC_XCV_TYPE RGMII > #define CONFIG_FEC_MXC_PHYADDR 0 > #define FEC_QUIRK_ENET_MAC > -#define IMX_FEC_BASE 0x30BE0000 > > #endif > diff --git a/include/configs/imx8mm_evk.h b/include/configs/imx8mm_evk.h > index c7022ef0f7..771eaf80d5 100644 > --- a/include/configs/imx8mm_evk.h > +++ b/include/configs/imx8mm_evk.h > @@ -89,6 +89,4 @@ > #define CONFIG_FEC_MXC_PHYADDR 0 > #define FEC_QUIRK_ENET_MAC > > -#define IMX_FEC_BASE 0x30BE0000 > - > #endif > diff --git a/include/configs/imx8mm_venice.h b/include/configs/imx8mm_venice.h > index 7ab11cc8fb..a828f48d2e 100644 > --- a/include/configs/imx8mm_venice.h > +++ b/include/configs/imx8mm_venice.h > @@ -109,6 +109,5 @@ > #define CONFIG_FEC_XCV_TYPE RGMII > #define CONFIG_FEC_MXC_PHYADDR 0 > #define FEC_QUIRK_ENET_MAC > -#define IMX_FEC_BASE 0x30BE0000 > > #endif > diff --git a/include/configs/imx8mn_beacon.h b/include/configs/imx8mn_beacon.h > index e2e322bb4d..e54b87c76a 100644 > --- a/include/configs/imx8mn_beacon.h > +++ b/include/configs/imx8mn_beacon.h > @@ -126,7 +126,6 @@ > #define CONFIG_FEC_XCV_TYPE RGMII > #define CONFIG_FEC_MXC_PHYADDR 0 > #define FEC_QUIRK_ENET_MAC > -#define IMX_FEC_BASE 0x30BE0000 > #endif /* CONFIG_FEC_MXC */ > > #endif > diff --git a/include/configs/imx8mq_evk.h b/include/configs/imx8mq_evk.h > index 4aaed3ae7d..1a472588ac 100644 > --- a/include/configs/imx8mq_evk.h > +++ b/include/configs/imx8mq_evk.h > @@ -43,8 +43,6 @@ > #define CONFIG_FEC_XCV_TYPE RGMII > #define CONFIG_FEC_MXC_PHYADDR 0 > #define FEC_QUIRK_ENET_MAC > - > -#define IMX_FEC_BASE 0x30BE0000 > #endif > > #ifndef CONFIG_SPL_BUILD > diff --git a/include/configs/imx8mq_phanbell.h > b/include/configs/imx8mq_phanbell.h > index 16a2c2cf9d..1e1c186aed 100644 > --- a/include/configs/imx8mq_phanbell.h > +++ b/include/configs/imx8mq_phanbell.h > @@ -37,8 +37,6 @@ > #define CONFIG_FEC_XCV_TYPE RGMII > #define CONFIG_FEC_MXC_PHYADDR 0 > #define FEC_QUIRK_ENET_MAC > - > -#define IMX_FEC_BASE 0x30BE0000 > #endif > > #define CONFIG_MFG_ENV_SETTINGS \ > diff --git a/include/configs/imx8ulp_evk.h b/include/configs/imx8ulp_evk.h > index 7da6802aa5..666306c028 100644 > --- a/include/configs/imx8ulp_evk.h > +++ b/include/configs/imx8ulp_evk.h > @@ -34,8 +34,6 @@ > > #define CONFIG_FEC_XCV_TYPE RMII > #define CONFIG_FEC_MXC_PHYADDR 1 > - > -#define IMX_FEC_BASE 0x29950000 > #endif > > #ifdef CONFIG_DISTRO_DEFAULTS > diff --git a/include/configs/kontron_pitx_imx8m.h > b/include/configs/kontron_pitx_imx8m.h > index 0f96b905ab..6f426cb08c 100644 > --- a/include/configs/kontron_pitx_imx8m.h > +++ b/include/configs/kontron_pitx_imx8m.h > @@ -43,7 +43,6 @@ > #define CONFIG_FEC_MXC_PHYADDR 0 > #define FEC_QUIRK_ENET_MAC > > -#define IMX_FEC_BASE 0x30BE0000 > #define PHY_ANEG_TIMEOUT 20000 > > #endif > diff --git a/include/configs/pico-imx8mq.h b/include/configs/pico-imx8mq.h > index 7bfa79059a..08204779d8 100644 > --- a/include/configs/pico-imx8mq.h > +++ b/include/configs/pico-imx8mq.h > @@ -37,8 +37,6 @@ > #define CONFIG_FEC_XCV_TYPE RGMII > #define CONFIG_FEC_MXC_PHYADDR 1 > #define FEC_QUIRK_ENET_MAC > - > -#define IMX_FEC_BASE 0x30BE0000 > #endif > > /* Initial environment variables */ > diff --git a/include/configs/verdin-imx8mm.h b/include/configs/verdin-imx8mm.h > index 17583c0a6a..859b62d6f7 100644 > --- a/include/configs/verdin-imx8mm.h > +++ b/include/configs/verdin-imx8mm.h > @@ -107,7 +107,6 @@ > #define CONFIG_FEC_XCV_TYPE RGMII > #define CONFIG_FEC_MXC_PHYADDR 7 > #define FEC_QUIRK_ENET_MAC > -#define IMX_FEC_BASE 0x30BE0000 > > /* USB Configs */ > #define CONFIG_EHCI_HCD_INIT_AFTER_RESET
