On 3/1/22 15:58, Simon Glass wrote:
Hi Michal,

On Wed, 23 Feb 2022 at 08:21, Michal Simek <michal.si...@xilinx.com> wrote:

From: T Karthik Reddy <t.karthik.re...@xilinx.com>

slg7xl45106 is i2c based 8-bit gpo expander, gpo pins are set and get by
writing and reading corresponding gpo bit value into its data register.

Signed-off-by: T Karthik Reddy <t.karthik.re...@xilinx.com>
Signed-off-by: Michal Simek <michal.si...@xilinx.com>
---

  MAINTAINERS                     |   1 +
  drivers/gpio/Kconfig            |   8 +++
  drivers/gpio/Makefile           |   1 +
  drivers/gpio/gpio_slg7xl45106.c | 115 ++++++++++++++++++++++++++++++++
  4 files changed, 125 insertions(+)
  create mode 100644 drivers/gpio/gpio_slg7xl45106.c

You might consider reducing the length of the 'slg7xl45106_i2c_gpo' prefix.

Also did you know about dm_i2c_reg_clrset() ?

nope but logic there is a little bit different compare to what I need to do.
It can be done but this I can't see this as a problem.


Reviewed-by: Simon Glass <s...@chromium.org>

Thanks,
Michal

Reply via email to