Hi Jagan, On 3/12/22 10:02, Jagan Teki wrote: > On Sat, Jan 8, 2022 at 12:04 AM Johan Jonker <jbx6...@gmail.com> wrote: >> >> The Rockchip SoCs rk3066/rk3188 have mmc DT nodes >> with as compatible string "rockchip,rk2928-dw-mshc". >> Add support to the existing driver with help of >> a DM_DRIVER_ALIAS. >> >> This type needs a permanent enabled fifo. >> The other Rockchip SoCs not always have the property >> "fifo-mode" in the TPL/SPL DT nodes, so dtplat structures >
> No, it is not true. we have property for spl/tpl to enable that. > "u-boot,spl-fifo-mode" This is not usable for rk3066/rk3188 and OF_PLATDATA in combination with c code as there's no guaranty that other models have this property in the dtplat structure. It's about finding a solution for disabling fifo-mode and OF_PLATDATA. There's also a V2 with a more generic approach. Could you have a look at it as well. Whatever which method is preferred. #if CONFIG_IS_ENABLED(OF_PLATDATA) struct dtd_rockchip_rk3288_dw_mshc dtplat; #endif Johan