On Thu, Mar 24, 2022 at 10:54:33PM +0900, Masahisa Kojima wrote:
> U-Boot menu framework(common/menu.c) returns 1 if it is successful,
> returns negative value if it fails.
>
> Signed-off-by: Masahisa Kojima <masahisa.koj...@linaro.org>
> ---
> Newly added in v4
>
> cmd/bootmenu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/cmd/bootmenu.c b/cmd/bootmenu.c
> index 409ef9a848..d573487272 100644
> --- a/cmd/bootmenu.c
> +++ b/cmd/bootmenu.c
> @@ -463,7 +463,7 @@ static void bootmenu_show(int delay)
> }
>
> for (iter = bootmenu->first; iter; iter = iter->next) {
> - if (!menu_item_add(menu, iter->key, iter))
> + if (menu_item_add(menu, iter->key, iter) != 1)
> goto cleanup;
> }
>
> @@ -476,7 +476,7 @@ static void bootmenu_show(int delay)
>
> init = 1;
>
> - if (menu_get_choice(menu, &choice)) {
> + if (menu_get_choice(menu, &choice) == 1) {
> iter = choice;
> title = strdup(iter->title);
> command = strdup(iter->command);
> --
> 2.17.1
>
Acked-by: Ilias Apalodimas <ilias.apalodi...@linaro.org>
