On Sat, Nov 13, 2021 at 11:14:28AM -0700, Simon Glass wrote: > On Tue, 9 Nov 2021 at 05:03, Andy Shevchenko > <andriy.shevche...@linux.intel.com> wrote: > > > > debug_hex_dump() and debug_hex_dump_bytes() conditionally print > > the dump based on DEBUG definition. > > > > Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> > > --- > > include/hexdump.h | 4 ++++ > > lib/hexdump.c | 60 ++++++++++++++++++++++++++++++++++++++++------- > > 2 files changed, 56 insertions(+), 8 deletions(-) > > +Heinrich Schuchardt
Heinrich, it's several months passed. What should we do? > Is it possible to resolve this in the header file? It is a bit odd to > have to add DEBUG to hexdump.c in order to get debug output. > > Note also the logging system so you can do > > log(LOG_CATEGORY, dbg ? LOGL_DEBUG : LOGL_INFO, "fmt ...", ...) -- With Best Regards, Andy Shevchenko
