On Thu, Mar 3, 2022 at 9:55 AM Ramon Fried <rfried....@gmail.com> wrote: > > On Tue, Mar 1, 2022 at 10:38 PM Joe Hershberger <joe.hershber...@ni.com> > wrote: > > > > On Tue, Mar 1, 2022 at 2:15 PM Tim Harvey <thar...@gateworks.com> wrote: > > > > > > When gpio_request_by_name allocates a gpio output it by default will > > > de-assert the gpio which for phy-reset will take the PHY out of reset. > > > As this occurs before eth_phy_reset is called to assert the reset > > > line it can cause undesired affects if reset timings are not properly > > > met. > > > > > > Configure the gpio with GPIOD_IS_OUT_ACTIVE so that reset is kept active > > > (reset asserted) to avoid this. > > > > > > Cc: Sean Anderson <sean.ander...@seco.com> > > > Signed-off-by: Tim Harvey <thar...@gateworks.com> > > > > Acked-by: Joe Hershberger <joe.hershber...@ni.com> > Reviewed-by: Ramon Fried <rfried....@gmail.com> Applied to u-boot-net/next Thanks, Ramon