On 15/04/22 9:57 pm, Tom Rini wrote: > On Fri, Apr 15, 2022 at 07:39:24PM +0530, Vignesh Raghavendra wrote: > > [snip] >> diff --git a/arch/arm/mach-k3/am625_init.c b/arch/arm/mach-k3/am625_init.c >> new file mode 100644 >> index 0000000000..ee902a774e >> --- /dev/null >> +++ b/arch/arm/mach-k3/am625_init.c >> @@ -0,0 +1,254 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * AM625: SoC specific initialization >> + * >> + * Copyright (C) 2020-2022 Texas Instruments Incorporated - >> https://www.ti.com/ >> + * Suman Anna <s-a...@ti.com> >> + */ >> + >> +#include <common.h> >> +#include <spl.h> >> +#include <asm/io.h> >> +#include <asm/arch/hardware.h> >> +#include <asm/arch/sysfw-loader.h> >> +#include "common.h" >> +#include <dm.h> >> +#include <dm/uclass-internal.h> >> +#include <dm/pinctrl.h> > > Er, common.h twice? Second one refers to arch/arm/mach-k3/common.h > Please re-check this, and then also drop common.h > (here and elsewhere) as it only includes other headers and we should > avoid it when possible. Sure, will do. > In fact, checkpatch.pl complains about both > dm.h and common.h so please address series-wide, thanks. > Unfortunately, it doesn't ;( Regards Vignesh
- [PATCH 00/11] TI: Add support for AM62 SoC Vignesh Raghavendra
- [PATCH 01/11] drivers: mmc: am654_sdhci: Add new ... Vignesh Raghavendra
- [PATCH 02/11] dt-bindings: pinctrl: k3: Introduce... Vignesh Raghavendra
- Re: [PATCH 02/11] dt-bindings: pinctrl: k3: I... Tom Rini
- Re: [PATCH 02/11] dt-bindings: pinctrl: k... Vignesh Raghavendra
- [PATCH 03/11] soc: ti: k3-socinfo: Add entry for ... Vignesh Raghavendra
- Re: [PATCH 03/11] soc: ti: k3-socinfo: Add en... Bryan Brattlof
- [PATCH 04/11] arm: mach-k3: Introduce the basic f... Vignesh Raghavendra
- Re: [PATCH 04/11] arm: mach-k3: Introduce the... Tom Rini
- Re: [PATCH 04/11] arm: mach-k3: Introduce... Vignesh Raghavendra
- Re: [PATCH 04/11] arm: mach-k3: Intro... Tom Rini
- Re: [PATCH 04/11] arm: mach-k3: ... Vignesh Raghavendra
- [PATCH 05/11] arm: mach-k3: am62: Introduce autog... Vignesh Raghavendra
- [PATCH 06/11] dma: ti: Add PSIL data for AM62x DM... Vignesh Raghavendra
- [PATCH 07/11] arm: dts: Introduce base AM62 SoC d... Vignesh Raghavendra
- Re: [PATCH 07/11] arm: dts: Introduce base AM... Tom Rini
- Re: [PATCH 07/11] arm: dts: Introduce bas... Vignesh Raghavendra
- [PATCH 08/11] board: ti: Introduce the basic file... Vignesh Raghavendra
- [PATCH 10/11] configs: Add configs for AM62x SK Vignesh Raghavendra
- [PATCH 11/11] doc: ti: Add readme for AM62x SK Vignesh Raghavendra