> Date: Wed, 20 Apr 2022 19:01:43 +0200 > From: Francesco Dolcini <francesco.dolc...@toradex.com> > > +Tom > > On Mon, Apr 11, 2022 at 08:17:55PM +0200, Francesco Dolcini wrote: > > Hello all, > > I have a need to pass the u-boot version string to the operating > > system and I'm thinking at adding `u-boot,version` property storing > > `version_string` in it in the FDT `chosen` node. > > > > Is this something that would be generally useful? Would be a patch like > > that acceptable in upstream u-boot? Is there any other obvious way to > > achieve something like that already implemented (using the cmdline would > > work without any code change, but probably not the nicest solution). > > Any concern on this Tom? I'm asking you directly since you recently > acknowledged another change [0] related to the chosen node. > > [0] https://lore.kernel.org/all/20220412201444.GN14282@bill-the-cat/
To be honest, putting this in the "chosen" node feels odd. Traditionally device trees have a node dedicated to the firmware. For example Sun OpenFirmware systems had a "openprom" node with a "version" property. And OpenPOWER systems have an "ibm,firmware-versions" node.