On Sun, May 01, 2022 at 04:44:16PM +0200, Pali Rohár wrote: > On Sunday 01 May 2022 10:39:39 Tom Rini wrote: > > On Sun, May 01, 2022 at 04:23:52PM +0200, Pali Rohár wrote: > > > > > This reverts commit c7fad78ec0ee41b72a58bebb61959570eb937ab1. > > > > > > This commit made configuration, understanding, maintenance, debugging and > > > future development of the powerpc/mpc85xx Local Bus Controller on P1/P2 > > > boards impossible. > > > > > > All preliminary Base and Option registers depends on other code and C > > > macros generated at C compile time and they comes from the other macros. > > > > > > For example, NOR base address and NOR options are set via macros > > > CONFIG_SYS_FLASH_BR_PRELIM and CONFIG_SYS_FLASH_OR_PRELIM. And then based > > > on other logic are filled correct values in to the correct macros > > > CONFIG_SYS_BR*_PRELIM and CONFIG_SYS_OR*_PRELIM. > > > > > > These config options are not user configurable options and therefore > > > should not appear in menuconfig. Moreover for P1/P2 boards they have > > > nothing with DDR driver, so they should not appear in drivers/ddr. > > > > > > This change was completely wrong direction, so revert it. It allows to > > > start fixing issues with FLASH, NOR, NAND and CPLD LBC configuration. > > > In current state it is impossible. > > > > > > See also thread for more details: > > > https://lore.kernel.org/u-boot/20220426181740.o2n7xfg46ytljcdx@pali/t/#u > > > > > > Signed-off-by: Pali Rohár <p...@kernel.org> > > > > NAK. We are not moving things back in to board config headers under > > CONFIG namespace. Some other solution is required. > > I spend time on this and I do not see any other solution. As explained > that commit just introduced more issues then what it brought, so it was > step backward, not forward. So please show other solution, if you do not > like this one.
Anything that I suggested in the previous thread about moving to board Kconfig files. Or move it to some other header and out of CONFIG namespace. Or if dtoc (doc/develop/driver-model/of-plat.rst) isn't sufficient today to pull out the infos to use at build time, expand it to cover this case as it would be useful for large numbers of other cases. -- Tom
signature.asc
Description: PGP signature