Hi Abdellatif, On Thu, May 12, 2022 at 03:04:38PM +0100, Abdellatif El Khlifi wrote: > On Mon, May 09, 2022 at 11:55:14AM +0100, Abdellatif El Khlifi wrote: > > On Fri, Apr 15, 2022 at 11:43:25AM -0400, Tom Rini wrote: > > > On Fri, Apr 15, 2022 at 01:27:57PM +0100, abdellatif.elkhl...@arm.com > > > wrote: > > > > > > > From: Abdellatif El Khlifi <abdellatif.elkhl...@arm.com> > > > > > > > > This patchset adds support for Arm FF-A (Arm Firmware Framework for > > > > Armv8-A v1.0). > > > > > > > > FF-A support is generic by design and can be used by any Arm platform. > > > > > > > > The features added are as follows: > > > > > > > > 1/ FF-A bus driver > > > > 2/ armffa command > > > > 3/ FF-A Sandbox driver > > > > 4/ FF-A Sandbox test cases > > > > 5/ FF-A MM communication > > > > > > > > The suggested design considers FF-A as a discoverable bus. > > > > The Secure World is considered as one entity to communicate with using > > > > the FF-A bus. > > > > FF-A communication is handled by one device and one instance (the bus). > > > > This FF-A driver takes care of all the interactions between Normal world > > > > and Secure World. > > > > > > > > The Secure World firmware runs under TrustZone HW (such as Optee). The > > > > same approach was followed in the > > > > FF-A driver in Linux kernel > > > > (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/firmware/arm_ffa/bus.c?h=v5.15#n211)) > > > > > > > > Cc: Tom Rini <tr...@konsulko.com> > > > > Cc: Rob Herring <r...@kernel.org> > > > > Cc: Ilias Apalodimas <ilias.apalodi...@linaro.org> > > > > Cc: Achin Gupta <achin.gu...@arm.com> > > > > Cc: Simon Glass <s...@chromium.org> > > > > Cc: Vishnu Banavath <vishnu.banav...@arm.com> > > > > > > I don't see a changelog compared with v1. Are any of the comments there > > > addressed? Thanks. > > > > > > -- > > > Tom > > > > Thanks Tom. I'll add a changelog for future versions. > > > > The current Changelog: > > > > Changelog: > > =============== > > v2 (15 Apr 2022) > > * Make FF-A bus discoverable (remove device tree support, bind and probe > > FF-A device using device_bind and device_probe) > > > > v1 (29 Mar 2022) > > * FF-A bus driver with device tree support > > * armffa command > > * FF-A Sandbox driver > > * FF-A Sandbox test cases > > * FF-A MM communication > > > > Hello guys, gentle ping, any feedback about the implementation of FF-A as a > discoverable > bus ?
Apologies for the late reply, I was on vacation. I'll try having a closer look on patch #1-5 in the upcoming days. Can you take a look at my comments on patch #6 and reply? Thanks /Ilias